deniskuzZ commented on code in PR #6748:
URL: https://github.com/apache/hive/pull/6748#discussion_r3941008474
##########
beeline/pom.xml:
##########
@@ -294,6 +325,11 @@
<!-- Output: arch-specific subdirectory so x64 and arm64
coexist -->
<arg value="--dest"/>
<arg
value="${project.build.directory}/apache-hive-beeline-${project.version}/${installer.arch}"/>
+ <!-- Reduces the size of the output artifact -->
+ <arg value="--add-modules"/>
+ <arg
value="java.base,java.compiler,java.desktop,java.instrument,java.prefs,java.rmi,java.scripting,java.security.jgss,java.security.sasl,java.sql.rowset,jdk.httpserver,jdk.jfr,jdk.management,jdk.security.auth,jdk.unsupported"/>
Review Comment:
does this list come from
````
jdeps \
--multi-release 21 \
--ignore-missing-deps \
--print-module-deps \
beeline-standalone.jar
````
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
