Aggarwal-Raghav commented on code in PR #6749:
URL: https://github.com/apache/hive/pull/6749#discussion_r3941040286
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java:
##########
@@ -434,92 +470,39 @@ private static void commitTransaction(Catalog catalog,
CommitTransactionRequest
// only commit if validations passed previously
transactions.forEach(Transaction::commitTransaction);
}
-
- @SuppressWarnings({"MethodLength", "unchecked"})
+
+ @SuppressWarnings({"unchecked"})
private <T extends RESTResponse> T handleRequest(
Route route, Map<String, String> vars, Object body) {
- switch (route) {
- case CONFIG:
- return (T) config();
-
- case LIST_NAMESPACES:
- return (T) listNamespaces(vars);
-
- case CREATE_NAMESPACE:
- return (T) createNamespace(body);
-
- case NAMESPACE_EXISTS:
- return (T) namespaceExists(vars);
-
- case LOAD_NAMESPACE:
- return (T) loadNamespace(vars);
-
- case DROP_NAMESPACE:
- return (T) dropNamespace(vars);
-
- case UPDATE_NAMESPACE:
- return (T) updateNamespace(vars, body);
-
- case LIST_TABLES:
- return (T) listTables(vars);
-
- case CREATE_TABLE:
- return (T) createTable(vars, body);
-
- case DROP_TABLE:
- return (T) dropTable(vars);
-
- case TABLE_EXISTS:
- return (T) tableExists(vars);
-
- case LOAD_TABLE:
- return (T) loadTable(vars);
-
- case REGISTER_TABLE:
- return (T) registerTable(vars, body);
-
- case UPDATE_TABLE:
- return (T) updateTable(vars, body);
-
- case RENAME_TABLE:
- return (T) renameTable(body);
-
- case REPORT_METRICS:
- return (T) reportMetrics(vars, body);
-
- case COMMIT_TRANSACTION:
- return (T) commitTransaction(body);
-
- case LIST_VIEWS:
- return (T) listViews(vars);
-
- case CREATE_VIEW:
- return (T) createView(vars, body);
-
- case VIEW_EXISTS:
- return (T) viewExists(vars);
-
- case LOAD_VIEW:
- return (T) loadView(vars);
-
- case UPDATE_VIEW:
- return (T) updateView(vars, body);
-
- case RENAME_VIEW:
- return (T) renameView(body);
-
- case DROP_VIEW:
- return (T) dropView(vars);
-
- case REGISTER_VIEW:
- return (T) registerView(vars, body);
-
- default:
- }
- return null;
+ return (T) switch (route) {
+ case CONFIG -> config();
+ case LIST_NAMESPACES -> listNamespaces(vars);
+ case CREATE_NAMESPACE -> createNamespace(body);
+ case NAMESPACE_EXISTS -> namespaceExists(vars);
+ case LOAD_NAMESPACE -> loadNamespace(vars);
+ case DROP_NAMESPACE -> dropNamespace(vars);
+ case UPDATE_NAMESPACE -> updateNamespace(vars, body);
+ case LIST_TABLES -> listTables(vars);
+ case CREATE_TABLE -> createTable(vars, body);
+ case DROP_TABLE -> dropTable(vars);
+ case TABLE_EXISTS -> tableExists(vars);
+ case LOAD_TABLE -> loadTable(vars);
+ case REGISTER_TABLE -> registerTable(vars, body);
+ case UPDATE_TABLE -> updateTable(vars, body);
+ case RENAME_TABLE -> renameTable(body);
+ case REPORT_METRICS -> reportMetrics(vars, body);
+ case COMMIT_TRANSACTION -> commitTransaction(body);
+ case LIST_VIEWS -> listViews(vars);
+ case CREATE_VIEW -> createView(vars, body);
+ case VIEW_EXISTS -> viewExists(vars);
+ case LOAD_VIEW -> loadView(vars);
+ case UPDATE_VIEW -> updateView(vars, body);
+ case RENAME_VIEW -> renameView(body);
+ case DROP_VIEW -> dropView(vars);
+ case REGISTER_VIEW -> registerView(vars, body);
Review Comment:
IntelliJ said :-)
<img width="499" height="211" alt="Screenshot 2026-09-05 at 8 39 33 PM"
src="https://github.com/user-attachments/assets/fae60c7a-f34d-477b-8648-45cc3e1e6aa0";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
