soumyakanti3578 commented on code in PR #6851:
URL: https://github.com/apache/hive/pull/6851#discussion_r4593036030
##########
ql/src/java/org/apache/hadoop/hive/ql/io/SymbolicInputFormat.java:
##########
@@ -98,4 +102,58 @@ public void rework(HiveConf job, MapredWork work) throws
IOException {
work.getMapWork().removePathToPartitionInfo(toRemove);
}
}
+
+ /**
+ * Expands a symlink file line, accepting only matches under the symlink
file's directory or an allowed root.
+ */
+ static List<Path> resolveTargets(Configuration conf, Path symlinkFile,
List<Path> allowedRoots, String line)
+ throws IOException {
+ // Qualified against the default filesystem, so no filesystem is created
for an arbitrary scheme.
+ FileSystem defaultFs = FileSystem.get(conf);
Review Comment:
In the next commit resolveTargets no longer creates a FileSystem - each
caller creates the default one once and passes it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]