soumyakanti3578 commented on code in PR #6851:
URL: https://github.com/apache/hive/pull/6851#discussion_r4596530448
##########
ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java:
##########
@@ -192,8 +193,14 @@ private static void getTargetPathsFromSymlinksDirs(
fileSystem.open(symlink.getPath())));
String line;
while ((line = reader.readLine()) != null) {
- targetPaths.add(new Path(line));
- symlinkPaths.add(symlink.getPath());
Review Comment:
No new functionality, the glob was already expanded, just later. The raw
line was added to `targetPaths`
([L195](https://github.com/apache/hive/blob/7d315d76d7dd7a82f200d07559bea2e50e8a5d9a/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java#L195))
and passed to `getSplits`
([L158-L160](https://github.com/apache/hive/blob/7d315d76d7dd7a82f200d07559bea2e50e8a5d9a/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java#L158-L160)),
where `FileInputFormat` calls `globStatus` on it
([L277](https://github.com/apache/hadoop/blob/rel/release-3.4.2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/FileInputFormat.java#L277)).
`symlink_text_input_format.q` covers it since HIVE-12541
([symlink-with-regex.txt](https://github.com/apache/hive/blob/7d315d76d7dd7a82f200d07559bea2e50e8a5d9a/data/files/symlink-with-regex.txt)).
The expansion is moved here so each match can be checked against the allowed
roots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]