aw-was-here commented on a change in pull request #227:
URL: https://github.com/apache/yetus/pull/227#discussion_r735642175
##########
File path: precommit/src/main/shell/plugins.d/cc.sh
##########
@@ -68,5 +68,5 @@ function cc_logfilter
declare output=$2
#shellcheck disable=SC1117
- "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" > "${output}"
+ "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" | sort >
"${output}"
Review comment:
There is still a bug here with maven+github. Github will be given a
filename of '[WARNING] foo.c' which it won't know what to do with. So there
either needs to be a maven_cc_logfilter added or this filter changed to also
strip out the extra '[ERROR] ' (note the space!) and '[WARNING] ' and whatever
else maven adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
