aw-was-here commented on a change in pull request #227:
URL: https://github.com/apache/yetus/pull/227#discussion_r735643659



##########
File path: precommit/src/main/shell/plugins.d/cc.sh
##########
@@ -68,5 +68,5 @@ function cc_logfilter
   declare output=$2
 
   #shellcheck disable=SC1117
-  "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" > "${output}"
+  "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" | sort > 
"${output}"

Review comment:
       and, actually, there is yet another bug here...  ${BASEDIR} should get 
pulled out of the filename.  In the end, output should be:
   
   ```
   
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:257:3:
 warning: implicit declaration of function ‘dlsym_CRYPTO_set_id_callback’; did 
you mean ‘CRYPTO_set_id_callback’? [-Wimplicit-function-declaration]
   ```
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to