Am 15. Juli 2017 08:04:42 MESZ schrieb elextr <[email protected]>: >@kugel- NULL `doc` is only prevented from something hidden in the >context, in this case UI sensitivity. The `doc` pointer may be NULL >and yes you are correct, the `doc->file_name` can be NULL. > >Geany is nowhere near exhaustively tested to be able to have some >reasonable guarantee that asserts will not be hit by users, so we >should not be inserting crashers like assert in the code. Just provide >a message if you must using the Glib logging capability that is already >set up in Geany, but otherwise the original `if(doc && doc->file_name)` >is file. > >-- >You are receiving this because you were mentioned. >Reply to this email directly or view it on GitHub: >https://github.com/geany/geany/pull/1537#issuecomment-315512679
Whatever works. 3/4 devs with 3/4 opinions discussing over a tiny change like this is discouraging and not fruitful. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1537#issuecomment-315513242
