@codebrainz 

> This macro should probably be used in this PR, else navqueue won't work for 
> files that aren't saved yet (or is this an existing bug?).

This is existing behavior. The navqueue uses the filename as a unique 
identifier of a document. (It doesn’t really need them right now, because it 
evicts a document from the navqueue once it is closed — so could use a 
`GeanyDocument *` — but the comments there mention fixing that as a to-do.)

> If you're unlucky, it will do anything else. What happens is completely 
> undefined behaviour.

Fair enough. Coming from other languages I’m not really used to the concept of 
UB yet. (Does it *realistically* ever not crash though?..)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-315542239

Reply via email to