@kugel- commented on this pull request.
> + log "Signing Geany binary files"
+ for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+ for binary_file in $(ls ${binary_file_pattern}); do
+ sign_file ${binary_file}
+ done
+ done
+}
+
+
+convert_text_files_to_crlf() {
+ log "Converting line endings to CRLF in text files"
+ for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+ for text_file in $(ls ${text_file_pattern}); do
+ mime_type=$(file --brief --mime-type ${text_file})
+ case $mime_type in text/*)
+ unix2dos ${text_file}
I opened #3350
I would like to see the conversion to be removed from this PR since I'm not
even sure it's necessary at all. Don't recent Windows version deal fine with LF
line endings. I don't know if notepad alone is an indication but see
https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/, this fix
is included in Windows 10 and 11.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1041083868
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3315/review/1206754...@github.com>
