@eht16 commented on this pull request.


> +     log "Signing Geany binary files"
+       for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+               for binary_file in $(ls ${binary_file_pattern}); do
+                       sign_file ${binary_file}
+               done
+       done
+}
+
+
+convert_text_files_to_crlf() {
+       log "Converting line endings to CRLF in text files"
+       for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+               for text_file in $(ls ${text_file_pattern}); do
+                       mime_type=$(file --brief --mime-type ${text_file})
+                       case $mime_type in text/*)
+                               unix2dos ${text_file}

Could any of you open that issue?
I still don't get the problem you see, as outlined above, a GIT clone on 
Windows probably gives the correct line endings and so I'm not really able to 
create an issue for an issue I don't understand :).

Here we are talking about a native Linux clone with native LF line endings and 
those we need to convert. IMO this is special to the CI build and so needs to 
be done here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1020899688
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3315/review/1178238...@github.com>

Reply via email to