@b4n commented on this pull request.
> + /* FIXME: this is sub-stylable, but we can't > figure out the base + * style without the Scintilla instance -- and we can't simply + * assume that if the style ID is larger than the max possible + * one it's this, because SCE_C_IDENTIFIER is also sub-stylable... */ This I don't see how to fix short of having a separate API taking a `ScintillaObject` instead of a lexer ID. We *might* be able to store info about the allocated sub-style somewhere that could be accessed from here *if* we could rely on sub-style allocation to give predictable values. This would require Scintilla to actually be deterministic about that, which it might be, but likely not if some calls could happen adding or modifying substyles (think of a plugin that would mess with this). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3794#pullrequestreview-1946148904 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3794/review/1946148...@github.com>
