@b4n commented on this pull request.


> +                             /* FIXME: this is sub-stylable, but we can't 
> figure out the base
+                                * style without the Scintilla instance -- and 
we can't simply
+                                * assume that if the style ID is larger than 
the max possible
+                                * one it's this, because SCE_C_IDENTIFIER is 
also sub-stylable... */

Yes we do have one lever per instance, that's why we'd need the allocations to 
be the same for all of them for this to have a chance of working.

But really, I probably should look at callers for this to see if anybody 
actually doesn't have a Scintilla instance ready at hand when calling this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3794#discussion_r1535452209
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3794/review/1954594...@github.com>

Reply via email to