@elextr requested changes on this pull request.
In principle the right click menu should be context related, like the `Open
Selected File` entry[^1]. So it might be better to add these new items to a
normal menu, and then they can be given a keyboard accelerator and even a
shortcut as well.
I suggest that adding a separate command for terminal would be better than
using the existing command and substituting nothing for `%c`. There is no
guarantee that will produce a valid command. There is plenty of space in the
Tools Preferences page.
Which version of glade did you use? there seems to be a lot of unrelated change
noise.
I have only had a quick look review so far.
[^1]: Yes yes I know it has accumulated non-context related things over the
years, but thats no excuse to continue the trend.
> in the command are substituted with the run script name, see
`Terminal emulators`_.
+File Manager
+ The command to use to open a file manager. Occurences of %d
+ are substituted with a directory in which to open it.
+
Say _what_ is substituted for %d directory of current file or home dir if no
files open, its up to the command to determine what to do with that.
> @@ -73,37 +73,40 @@
/* some default settings which are used at the very first start of Geany to
fill
* the configuration file */
-#define GEANY_MAX_SYMBOLLIST_HEIGHT 10
-#define GEANY_MIN_SYMBOLLIST_CHARS 4
-#define GEANY_MSGWIN_HEIGHT 208
-#define GEANY_DISK_CHECK_TIMEOUT 30
-#define GEANY_DEFAULT_TOOLS_MAKE "make"
+#define GEANY_MAX_SYMBOLLIST_HEIGHT 10
+#define GEANY_MIN_SYMBOLLIST_CHARS 4
+#define GEANY_MSGWIN_HEIGHT 208
+#define GEANY_DISK_CHECK_TIMEOUT 30
+#define GEANY_DEFAULT_TOOLS_MAKE "make"
Why all these noise changes?
> gchar *term_cmd; /**<
> terminal emulator command */
+ gchar *file_manager_cmd; /**< file
manager command */
This struct is in the plugin API, so add new fields at the end to avoid
breaking the ABI, increment the API, see HACKING.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3813#pullrequestreview-1981492918
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3813/review/1981492...@github.com>
