> Didn't we have native dialogs a while ago, at least on Windows? So this > brings that back, basically?
Yes, but I think the problem wasn't the dialogs themselves (apart from the fact they were some "old" open dialogs), but rather the fact they were implemented using Windows API that nobody understood well. The API of `GtkFileChooserNative` is pretty much like `GtkFileChooser` except it isn't a widget and you cannot put custom widgets inside it. > You hard-coded the native dialogs. This isn't meant to be the final implementation - as said in the PR description, I asked whether using them would be acceptable in Geany and implemented it only for the open dialog for some testing. I don't want to spend much time on something that nobody likes so here I just wanted some initial feedback. Making this feature optional is surely an option but if it's done that way, I'd lean towards using the native dialogs by default. > As they don't offer all the features of our dialog (renaming a file, for > example) I didn't even know it was possible to rename a file using the Open dialog - how does one do that? I was talking about these options: <img width="878" alt="Screenshot 2024-04-30 at 15 21 11" src="https://github.com/geany/geany/assets/713965/46cf8725-cf6d-4acf-9cad-51c65eed02b7";> which are a custom widget inserted to the open dialog and which I personally have never used (I just tend to open the file and modify what's needed afterwards in Geany - especially with file encoding one cannot be sure before seeing how the file displays). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2085408678 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3861/c2085408...@github.com>
