> Alright, I made the suggested changes:
> 
>     1. I made GtkFileChooserNative configurable, by default enabled on macOS 
> and Windows, disabled on Linux.

Sweet, works perfectly.

>     3. Not sure if intentional or if it's some left-over but `ui_utils.c` 
> still contains native win32 dialogs: 
> https://github.com/geany/geany/blob/11b4a00a3020b1c9ace3d3ae65aa5ec7d5ff84e0/src/ui_utils.c#L2012
>         I replaced those with GtkFileChooserNative and eliminated the native 
> code in win32.c.

I guess it's some sort of left-over because it wasn't as buggy as the full file 
dialogs and so they were out of my focus.
Thanks for cleaning up my dirt :D.

>     4. For now I didn't modify plugins which also contain some GtkFileChooser 
> code but I could do the same for them too if desired.

I think this improve the overall user experience. Though maybe this can be done 
later as well and maybe also by the respective plugin maintainers (at least for 
those plugins which still have an active maintainer).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2132197631
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3861/c2132197...@github.com>

Reply via email to