@techee commented on this pull request.
> +
+
+typedef struct {
+ gboolean (*autocomplete_provided)(GeanyDocument *doc);
+ void (*autocomplete_perform)(GeanyDocument *doc, gboolean force);
+
+ gboolean (*calltips_provided)(GeanyDocument *doc);
+ void (*calltips_show)(GeanyDocument *doc, gboolean force);
+
+ gboolean (*goto_provided)(GeanyDocument *doc);
+ void (*goto_perform)(GeanyDocument *doc, gint pos, gboolean definition);
+
+ gboolean (*doc_symbols_provided)(GeanyDocument *doc);
+ GPtrArray *(*doc_symbols_get)(GeanyDocument *doc);
+
+ gboolean (*symbol_highlight_provided)(GeanyDocument *doc);
Basically there's no need for any `perform()` here. In the other API calls it
is necessary because the plugin needs to know when e.g. a keybinding invoking
goto definition/declaration was pressed to perform the corresponding action.
Here, instead, the plugin can perform the highlighting by itself e.g. when the
current document becomes visible or the user types something and the only thing
necessary is that geany knows highlighting is provided by the plugin so it
doesn't do anything.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#discussion_r1625113237
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3849/review/2094953...@github.com>
