@b4n commented on this pull request.
> + if (!EMPTY(parent->scope))
+ {
+ if (!g_str_has_prefix(tag->scope, parent->scope))
+ return FALSE;
+ scope_len = strlen(parent->scope);
+
+ if (!g_str_has_prefix(tag->scope + scope_len, scope_sep))
+ return FALSE;
+ scope_len += strlen(scope_sep);
+ }
+
+ if (!g_str_has_prefix(tag->scope + scope_len, parent->name))
+ return FALSE;
+ scope_len += strlen(parent->name);
+
+ if (scope_len == strlen(tag->scope))
Nitpick: I'd rather write `! tag->scope[scope_len]` or one of the many
equivalents that avoid yet another `strlen()`
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4063#pullrequestreview-2453611647
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4063/review/[email protected]>
