@icy commented on this pull request.
> + if (window_width >= 500) {
+ window_width = window_width / 2;
+ }
> Is 500 really too big? Otherwise if the goal is to make it bigger, then the
> threshold should be whatever makes it larger than 500 (math suggests it'd be
> 1000).
When the main window has some moderate size , I want(ed) the commander's panel
has relatively smaller size. When the main window is too small (< 500), I
want to see the commander of the same size (otherwise it's too small to show
any thing if I get it right.)
I admit my calculation is bad. It's better that I used some min() function
instead.
> Also note that this is not dynamic during a Geany session, it's only the
> default size when opening the panel for the first time, if you change the
> Geany window size later it won't affect this. This is not necessarily an
> issue though
I've also noticed that, thanks for your confirmation.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1394#discussion_r1943467365
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1394/review/[email protected]>
