@icy commented on this pull request.


> +    gchar *dirname = g_path_get_dirname (DOC_FILENAME (documents[i]));
+    gchar *dirname_basename = g_path_get_basename (dirname);
+    gchar *label = g_markup_printf_escaped ("<big>%s/%s</big>\n"
                                             "<small><i>%s</i></small>",
+                                            dirname_basename,

I agree that your suggestion  would be better and would address all cases well. 

I was actually thinking if I could do some computing for all items before 
getting the best display option. However, I  think that would require more 
resources, and I don't think it's not worth trading. I was really getting some 
hard time using our plugin, and the best idea I've been able to share, is this 
(wip) pull request.

I will spend a little more time on this, at least for my own usage. If you 
think there should be more efficient way to address the problem, I can help to 
open an issue and hopefully someone from the community can help.

Thank you a lot for your time. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1394#discussion_r1943491624
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1394/review/[email protected]>

Reply via email to