@b4n commented on this pull request.
> + p->startLine == q->startLine && p->startCharOffset == > q->startCharOffset && + p->endLine == q->endLine && p->endCharOffset == q->endCharOffset) As mentioned in https://github.com/geany/geany/pull/4303#issuecomment-2972662255, what about just comparing the starts? Of course it could lead to missing tags if a subsequent promise is longer than the current one, but OTOH it's very likely to trigger the issue, and very unlikely not to be an error. Isn't it? ```suggestion p->startLine == q->startLine && p->startCharOffset == q->startCharOffset) ``` OTOH, at least if we drop the identical ones, it's not gonna be infinite, there's only so many (however large) combinations of offsets in a given input. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4330#pullrequestreview-2928268333 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4330/review/[email protected]>
