@techee commented on this pull request.
> + p->startLine == q->startLine && p->startCharOffset == > q->startCharOffset && + p->endLine == q->endLine && p->endCharOffset == q->endCharOffset) Agreed. Comparing just the beginning reduces the number of possible combinations that have to be parsed in the worst case scenario. In addition, I think we could also discard promises whose `start > existing_promise_start && start < existing_promise_end && end > existing_promise_end` because such overlapping promises should never be created legally (of course, the problem may be on the already inserted promise side, hard to tell, but this means there's some underlying problem in the parser which has to be fixed anyway). Am I right? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4330#discussion_r2147297905 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4330/review/[email protected]>
