@techee requested changes on this pull request.
Apart from the reused `tm_tag_struct_t`, LGTM (no guarantees I haven't missed
anything).
> @@ -186,6 +186,29 @@ static TMParserMapGroup group_PHP[] = {
{N_("Constants"), TM_ICON_MACRO, tm_tag_macro_t},
{N_("Variables"), TM_ICON_VAR, tm_tag_variable_t | tm_tag_local_var_t},
{N_("Traits"), TM_ICON_STRUCT, tm_tag_struct_t},
+ /* Embedded JavaScript */
+ {N_("Properties"), TM_ICON_MEMBER, tm_tag_field_t},
+ /* Embedded HTML */
+ {N_("Anchors"), TM_ICON_NONE, tm_tag_typedef_t},
+ {N_("H1 Headings"), TM_ICON_NONE, tm_tag_struct_t},
`tm_tag_struct_t` is already used for "Traits" above.
> @@ -186,6 +186,29 @@ static TMParserMapGroup group_PHP[] = {
{N_("Constants"), TM_ICON_MACRO, tm_tag_macro_t},
{N_("Variables"), TM_ICON_VAR, tm_tag_variable_t | tm_tag_local_var_t},
{N_("Traits"), TM_ICON_STRUCT, tm_tag_struct_t},
+ /* Embedded JavaScript */
+ {N_("Properties"), TM_ICON_MEMBER, tm_tag_field_t},
+ /* Embedded HTML */
+ {N_("Anchors"), TM_ICON_NONE, tm_tag_typedef_t},
+ {N_("H1 Headings"), TM_ICON_NONE, tm_tag_struct_t},
`tm_tag_struct_t` is already used for "Traits" above.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4335#pullrequestreview-2930207678
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4335/review/[email protected]>
