@techee commented on this pull request.
> - {N_("Functions"), TM_ICON_NONE, tm_tag_function_t}, // javascript
> functions from subparser
{N_("Anchors"), TM_ICON_NONE, tm_tag_member_t},
{N_("H1 Headings"), TM_ICON_NONE, tm_tag_namespace_t},
{N_("H2 Headings"), TM_ICON_NONE, tm_tag_class_t},
{N_("H3 Headings"), TM_ICON_NONE, tm_tag_variable_t},
+ /* Embedded languages (JavaScript & PHP) */
+ {N_("Namespaces"), TM_ICON_NAMESPACE, tm_tag_package_t},
+ {N_("Interfaces"), TM_ICON_STRUCT, tm_tag_interface_t},
+ {N_("Classes"), TM_ICON_CLASS, tm_tag_typedef_t},
+ {N_("Functions"), TM_ICON_METHOD, tm_tag_function_t},
+ {N_("Constants"), TM_ICON_MACRO, tm_tag_macro_t},
+ {N_("Variables"), TM_ICON_VAR, tm_tag_union_t | tm_tag_local_var_t},
+ {N_("Traits"), TM_ICON_STRUCT, tm_tag_struct_t},
+ {N_("Properties"), TM_ICON_MEMBER, tm_tag_field_t},
> As the order here is the order of the groups in the tree, this actually
> changes where JS functions land. I see 3 options here:
> - have HTML stuff first, as it's the primary language here (e.g. what's in
> this diff)
I've noticed this change and I think you did the right thing here - splitting
the group into two parts would be confusing and having tags of the primary
language below something else probably isn't intuitive either. And such an
ordering is easily applicable for all other languages using subparsers.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4335#discussion_r2149490628
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4335/review/[email protected]>
