@b4n commented on this pull request.
> + if [[ "x$LUA_PKG_NAME" = "xluajit" ]] ; then + LUA_VERSION=2.0 + LUA_VERSION_BOUNDARY=3.0 + elif [[ "x$LUA_PKG_NAME" = "xlua51" ]] ; then + LUA_VERSION=5.1 + LUA_VERSION_BOUNDARY=5.2 + elif [[ "x$LUA_PKG_NAME" = "xlua52" ]] ; then + LUA_VERSION=5.2 + LUA_VERSION_BOUNDARY=5.3 + elif [[ "x$LUA_PKG_NAME" = "xlua53" ]] ; then + LUA_VERSION=5.3 + LUA_VERSION_BOUNDARY=5.4 + elif [[ "x$LUA_PKG_NAME" = "xlua54" ]] ; then + LUA_VERSION=5.4 + LUA_VERSION_BOUNDARY=5.5 + else + LUA_VERSION=5.1 + LUA_VERSION_BOUNDARY=5.5 + fi Feels to me like the package-specific boundaries are only needed for `luajit` that has different package versioning, the rest should be fine anywhere ` >= 5.1 && < 5.5`, just that there won't ever be a `lua53 == 5.4` or a `lua54 == 5.2`, right? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#pullrequestreview-2989641733 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1238/review/[email protected]>
