@b4n commented on this pull request.
> ) + AC_MSG_CHECKING([for Lua version]) + LUA_VERSION=`$PKG_CONFIG --modversion $LUA_PKG_NAME 2>/dev/null` + + if test -n "$LUA_VERSION"; then + AC_MSG_RESULT([$LUA_VERSION]) + case "$LUA_VERSION" in + 5.1*|5.2*|5.3*) + AC_MSG_WARN([Lua version $LUA_VERSION is EOL. Consider upgrading.]) it's cute and all, but I don't think it's the job of the plugin to do this *unless* you plan to drop support for it in an upcoming version of the plugin, in which case it should be more explicit. But either way, I don't think enough people actually will read such a warning for it to warrant the added complexity: if you wanna drop support for an older version later, just do so. Either people can upgrade then, or they won't, I doubt the warning here will help them plan ahead. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#pullrequestreview-2990383542 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1238/review/[email protected]>
