@techee commented on this pull request.
> ) + AC_MSG_CHECKING([for Lua version]) + LUA_VERSION=`$PKG_CONFIG --modversion $LUA_PKG_NAME 2>/dev/null` + + if test -n "$LUA_VERSION"; then + AC_MSG_RESULT([$LUA_VERSION]) + case "$LUA_VERSION" in + 5.1*|5.2*|5.3*) + AC_MSG_WARN([Lua version $LUA_VERSION is EOL. Consider upgrading.]) > This is mainly to address @techee concern of supporting too many Lua > versions. While I have no definite plans to drop (building with) Lua 5.1, I > do consider Lua 5.4 and LuaJIT to be the preferred implementations after this > PR. I was mostly looking at it from my perspective that if I were to maintain the plugin, I would like to eliminate as many variables from bug reports as possible. But you are the maintainer and it's your time :-P > The message could be made stronger, "Lua version __ is EOL and unsupported." > But I don't want to stop people from actually using whatever version they > choose until incompatible changes become necessary. I think what @b4n wanted to say is that the whole message thing should go away. Since you committed to supporting all the versions in the upcoming release, there's no need for such a message. If you decide to drop support of older lua versions in the future, just drop them (and it can be then mentioned in release notes). Lua 5.1 was released nearly 20 years ago and I think nobody will be too surprised if it's dropped. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#discussion_r2187527092 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1238/review/[email protected]>
