@techee First 2.1 issue breakage :) Current LSP doesn't build on GLib 2.58 (GP only depend on 2.56 through Geany 2.1).
We have 2 options: * Make LSP depend on 2.68 (for `g_string_replace()`) * Do something similar to this PR to support 2.56 (I don't have any 2.56 so I can't verify for sure, but could check the new API in 2.58 to manually check). * The most annoying piece might be the json-glib change, which might need to either be a patch, or conditionally defining `G_GNUC_FALLTHROUGH` from the build system (on GLib < 2.60) I know you want the patches against the LSP repo, but I'm starting it here because it's mostly concerning the GP integration. I can PR against that repo when we know what to do -- or you can take whatever you like and make your own, I don't mind :) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1476 -- Commit Summary -- * lsp: Fix build with GLib 2.58 -- File Changes -- M lsp/deps/json-glib/json-scanner.c (3) M lsp/src/lsp-autocomplete.c (45) M lsp/src/spawn/lspunixoutputstream.c (2) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1476.patch https://github.com/geany/geany-plugins/pull/1476.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1476 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/[email protected]>
