techee left a comment (geany/geany-plugins#1476) > @techee First 2.1 issue breakage :)
Nice, caused by me ;-) > Current LSP doesn't build on GLib 2.58 (GP only depend on 2.56 through Geany > 2.1). Out of curiosity - is it something you noticed by yourself or did someone else report this issue? Isn't there some compile-time glib macro we could use to always report issues like this? I've made this mistake several times already and I suspect it's not the last time. > The most annoying piece might be the json-glib change, which might need to > either be a patch, or conditionally defining G_GNUC_FALLTHROUGH from the > build system (on GLib < 2.60) Would it be hard to do using the build system? If it's not a big problem, I'd prefer that to modifying jsonrpc-glib. But if the result is something too complicated, I can e.g. save this diff to a patch file and apply it when updating to a newer version of jsonrpc-glib (which I think is pretty stable and not evolving too much so it might not be necessary to do normally). > I know you want the patches against the LSP repo, but I'm starting it here > because it's mostly concerning the GP integration. I can PR against that repo > when we know what to do -- or you can take whatever you like and make your > own, I don't mind :) Don't worry, it doesn't really matter - I have to apply the change to the other repo anyway. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1476#issuecomment-3052941683 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1476/[email protected]>
