wesm commented on a change in pull request #7088:
URL: https://github.com/apache/arrow/pull/7088#discussion_r419799536
##########
File path: cpp/src/arrow/csv/converter_benchmark.cc
##########
@@ -20,15 +20,67 @@
#include <sstream>
#include <string>
+#include "arrow/buffer.h"
#include "arrow/csv/converter.h"
#include "arrow/csv/options.h"
#include "arrow/csv/parser.h"
+#include "arrow/csv/reader.h"
#include "arrow/csv/test_common.h"
+#include "arrow/io/memory.h"
#include "arrow/testing/gtest_util.h"
+#include "arrow/util/value_parsing.h"
namespace arrow {
namespace csv {
+static std::shared_ptr<Buffer> GenerateTimestampsCSV(
+ const std::vector<std::string>& dates, int32_t cols, int32_t rows) {
+ std::stringstream ss;
+ for (int32_t row = 0; row < rows; ++row) {
+ for (int32_t col = 0; col < cols; ++col) {
+ ss << dates[rand() % dates.size()];
Review comment:
Removed this code in favor of your comment below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
