wesm commented on pull request #7088:
URL: https://github.com/apache/arrow/pull/7088#issuecomment-623031355
Hm unfortunately it seems that Howard Hinnant's date library does not fully
support gcc < 7 -- there are issues with `date::parse`
```
/usr/bin/ccache /usr/bin/g++-4.8 -DARROW_EXPORTING
-DARROW_EXTRA_ERROR_CONTEXT -DARROW_HAVE_AVX2 -DARROW_HAVE_SSE4_2 -DARROW_HDFS
-DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_NO_DEPRECATED_API
-DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4
-DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_ZLIB
-DARROW_WITH_ZSTD -DURI_STATIC_BUILD -Isrc -I../src -I../src/generated -isystem
../thirdparty/flatbuffers/include -isystem /home/wesm/cpp-toolchain/include
-isystem jemalloc_ep-prefix/src -isystem ../thirdparty/hadoop/include -ggdb -O0
-Wall -Wno-conversion -Wno-sign-conversion -Wno-unused-variable -Werror
-Wno-attributes -mavx2 -fno-omit-frame-pointer -g -fPIC -std=gnu++11 -MD -MT
src/arrow/CMakeFiles/arrow_objlib.dir/util/value_parsing.cc.o -MF
src/arrow/CMakeFiles/arrow_objlib.dir/util/value_parsing.cc.o.d -o
src/arrow/CMakeFiles/arrow_objlib.dir/util/value_parsing.cc.o -c
../src/arrow/util/value_parsing.cc
In file included from ../src/arrow/vendored/datetime.h:20:0,
from ../src/arrow/util/value_parsing.h:35,
from ../src/arrow/util/value_parsing.cc:18:
../src/arrow/vendored/datetime/date.h: In instantiation of
‘std::basic_istream<_CharT, _Traits>&
arrow_vendored::date::from_stream(std::basic_istream<_CharT, _Traits>&, const
CharT*, arrow_vendored::date::sys_time<Duration>&, std::basic_string<CharT,
Traits, Alloc>*, std::chrono::minutes*) [with Duration =
std::chrono::duration<long int>; CharT = char; Traits = std::char_traits<char>;
Alloc = std::allocator<char>; arrow_vendored::date::sys_time<Duration> =
std::chrono::time_point<std::chrono::_V2::system_clock,
std::chrono::duration<long int> >; std::chrono::minutes =
std::chrono::duration<int, std::ratio<60l> >]’:
../src/arrow/vendored/datetime/date.h:7823:74: required from
‘std::basic_istream<_CharT, _Traits>&
arrow_vendored::date::operator>>(std::basic_istream<_CharT, _Traits>&, const
arrow_vendored::date::parse_manip<Parsable, CharT, Traits, Alloc>&) [with
Parsable = std::chrono::time_point<std::chrono::_V2::system_clock,
std::chrono::duration<long int> >; CharT = char; Traits =
std::char_traits<char>; Alloc = std::allocator<char>]’
../src/arrow/util/value_parsing.cc:100:62: required from here
../src/arrow/vendored/datetime/date.h:4557:5: error: converting to
‘arrow_vendored::date::weekday’ from initializer list would use explicit
constructor ‘constexpr arrow_vendored::date::weekday::weekday(unsigned int)’
fields() = default;
^
../src/arrow/vendored/datetime/date.h:7752:20: note: synthesized method
‘arrow_vendored::date::fields<Duration>::fields() [with Duration =
std::chrono::duration<long int>]’ first required here
fields<CT> fds{};
^
ninja: build stopped: subcommand failed.
```
This will have to be changed to use POSIX strptime for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
