zeapo commented on pull request #7309:
URL: https://github.com/apache/arrow/pull/7309#issuecomment-637601236
As per @houqp suggestion, here are the changes:
- match csv's infer schema:
- CSV:
https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L90-L95
- JSON:
https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR174-R177
- Mismatch: notice that the json's one return an `Arc<Schema>`. I don't
know if we should make the csv reader match this or the other way arround.
Especially that `Reader::new` takes `Arc<Schema>`
- new function for seekable:
https://github.com/apache/arrow/pull/7309/files?diff=split&w=1#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR159-R168
- match csv's `Reader::from_buf_reader`:
- csv:
https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L235-L242
- json:
https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR377-R382
- match csv's `Reader::new`:
- csv:
https://github.com/apache/arrow/blob/master/rust/arrow/src/csv/reader.rs#L198-L214
- json:
https://github.com/apache/arrow/pull/7309/files#diff-3fa6fc3c0ee201f5a3a1a5d25d0062ffR341-R347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
