zeapo commented on a change in pull request #7309:
URL: https://github.com/apache/arrow/pull/7309#discussion_r434824558



##########
File path: rust/arrow/src/json/reader.rs
##########
@@ -157,9 +156,26 @@ fn generate_schema(spec: HashMap<String, 
HashSet<DataType>>) -> Result<Arc<Schem
 /// `max_read_records` controlling the maximum number of records to read.
 ///
 /// If `max_read_records` is not set, the whole file is read to infer its 
field types.
-fn infer_json_schema(file: File, max_read_records: Option<usize>) -> 
Result<Arc<Schema>> {
+pub fn infer_json_schema_from_seekable<R: Read + Seek>(

Review comment:
       Updated with additional examples and other tests at the end. could you 
please check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to