nevi-me commented on a change in pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#discussion_r435069031
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -122,7 +122,7 @@ impl Default for SortOptions {
fn default() -> Self {
Self {
descending: false,
- nulls_first: false,
+ nulls_first: true,
Review comment:
Okay, that's fine, we could set the default in DataFusion instead, but
the way you've done it is fine. I would have taken that as a lazy approach to
avoid changing all the test cases :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
