ctring commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644373157
@nealrichardson Once I made all the changes in the CMake file, I could pass the boost_ep build phase but failed at thrift_ep with the error that `typeof/incr_registration_group.hpp` was missing. ``` ...\build\boost_ep-prefix\src\boost_ep\boost/scope_exit.hpp(257,10): fatal error C1083: Cannot open include file: 'boost/typeof/incr_registration_group.hpp': No such file or directory (compiling source file C:\source\arrow\cpp\build\thrift_ep-prefix\src\thrift_ep\lib\cpp\src\thrift\windows\OverlappedSubmissionThread.cpp) [C:\source\arrow\cpp\build\thrift_ep-prefix\src\thrift_ep-build\lib\cpp\thrift_static.vcxproj] ``` From the error, you can tell the reason why this happened on Windows but not Linux: Thrift would additionally compile the file `windows\OverlappedSubmissionThread.cpp` on Windows, which required `boost/scope_exit.hpp`, which included `boost/typeof/incr_registration_group.hpp` I then copied the `boost/typeof/incr_registration_group.hpp` from the original Boost source to the boost_ep folder in the build tree. After that, I could build everything successfully, which means that header was the only missing file. I also ran the `trim-boost.sh` script to make sure the missing header file would be in the new bundle. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
