wesm commented on a change in pull request #7461:
URL: https://github.com/apache/arrow/pull/7461#discussion_r441522602
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare_test.cc
##########
@@ -368,23 +368,55 @@ TYPED_TEST(TestNumericCompareKernel, TestNullScalar) {
}
TYPED_TEST_SUITE(TestNumericCompareKernel, NumericArrowTypes);
-TYPED_TEST(TestNumericCompareKernel, RandomCompareArrayScalar) {
- using ScalarType = typename TypeTraits<TypeParam>::ScalarType;
- using CType = typename TypeTraits<TypeParam>::CType;
+template <typename Type>
+void DoRandomCompare(const std::shared_ptr<DataType>& type) {
+ using ScalarType = typename TypeTraits<Type>::ScalarType;
+ using CType = typename TypeTraits<Type>::CType;
auto rand = random::RandomArrayGenerator(0x5416447);
for (size_t i = 3; i < 10; i++) {
Review comment:
I'll remove this. I was copy and pasting what was already there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
