bkietz commented on a change in pull request #7461:
URL: https://github.com/apache/arrow/pull/7461#discussion_r441579699
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -787,6 +830,41 @@ ArrayKernelExec Integer(detail::GetTypeId get_id) {
}
}
+template <template <typename...> class Generator, typename Type0, typename...
Args>
+ArrayKernelExec IntegerBased(detail::GetTypeId get_id) {
Review comment:
FWIW, we have slight precedent for naming this
"GenerateForPhysicalInteger": `type_traits.h::is_physical_integer_type`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
