wesm commented on pull request #7143:
URL: https://github.com/apache/arrow/pull/7143#issuecomment-647694302
Here's what I see with gcc-8:
```
benchmark baseline
contender change % regression
1 BM_ReadColumn<true,Int32Type>/1/1 1.336 GiB/sec 1.880
GiB/sec 40.701 False
17 BM_ReadColumn<true,Int64Type>/1/1 2.224 GiB/sec 2.926
GiB/sec 31.567 False
14 BM_ReadColumn<true,Int32Type>/99/0 1.599 GiB/sec 2.001
GiB/sec 25.128 False
23 BM_ReadColumn<true,Int32Type>/99/50 1.601 GiB/sec 1.990
GiB/sec 24.300 False
21 BM_ReadColumn<true,Int64Type>/50/50 1002.325 MiB/sec 1.206
GiB/sec 23.171 False
12 BM_ReadColumn<true,Int32Type>/50/50 619.919 MiB/sec 758.845
MiB/sec 22.410 False
33 BM_ReadColumn<true,Int64Type>/45/25 1016.908 MiB/sec 1.212
GiB/sec 22.095 False
30 BM_ReadColumn<true,Int32Type>/50/0 620.068 MiB/sec 757.008
MiB/sec 22.085 False
34 BM_ReadColumn<true,Int64Type>/5/5 1.586 GiB/sec 1.935
GiB/sec 21.981 False
27 BM_ReadColumn<true,Int64Type>/99/0 2.539 GiB/sec 3.081
GiB/sec 21.308 False
13 BM_ReadColumn<true,Int64Type>/10/5 1.361 GiB/sec 1.644
GiB/sec 20.791 False
18 BM_ReadColumn<true,Int64Type>/50/1 1.002 GiB/sec 1.204
GiB/sec 20.174 False
26 BM_ReadColumn<true,Int64Type>/75/1 1.182 GiB/sec 1.419
GiB/sec 20.005 False
15 BM_ReadColumn<true,Int64Type>/99/50 2.532 GiB/sec 3.036
GiB/sec 19.890 False
11 BM_ReadColumn<true,Int64Type>/30/10 1.123 GiB/sec 1.322
GiB/sec 17.754 False
35 BM_ReadColumn<true,Int64Type>/25/10 1.187 GiB/sec 1.396
GiB/sec 17.558 False
25 BM_ReadColumn<true,Int32Type>/25/5 741.612 MiB/sec 870.530
MiB/sec 17.384 False
3 BM_ReadColumn<true,Int32Type>/10/10 859.032 MiB/sec 1005.688
MiB/sec 17.072 False
31 BM_ReadColumn<true,Int64Type>/35/10 1.095 GiB/sec 1.254
GiB/sec 14.528 False
20 BM_ReadColumn<true,BooleanType>/-1/1 712.571 MiB/sec 808.480
MiB/sec 13.460 False
5 BM_ReadColumn<true,DoubleType>/25/25 1.244 GiB/sec 1.399
GiB/sec 12.397 False
9 BM_ReadColumn<true,BooleanType>/5/10 460.741 MiB/sec 484.654
MiB/sec 5.190 False
7 BM_ReadColumn<false,BooleanType>/1/20 397.103 MiB/sec 412.517
MiB/sec 3.882 False
29 BM_ReadColumn<false,BooleanType>/-1/0 984.767 MiB/sec 994.483
MiB/sec 0.987 False
19 BM_ReadColumn<false,DoubleType>/-1/0 13.609 GiB/sec 13.738
GiB/sec 0.944 False
28 BM_ReadColumn<false,Int32Type>/-1/1 4.910 GiB/sec 4.702
GiB/sec -4.236 False
8 BM_ReadColumn<false,Int64Type>/-1/1 8.631 GiB/sec 8.000
GiB/sec -7.310 True
6 BM_ReadColumn<false,Int64Type>/-1/10 2.872 GiB/sec 2.329
GiB/sec -18.912 True
32 BM_ReadColumn<false,Int32Type>/-1/10 1.457 GiB/sec 1.099
GiB/sec -24.615 True
22 BM_ReadColumn<true,DoubleType>/10/50 1.433 GiB/sec 964.501
MiB/sec -34.267 True
24 BM_ReadColumn<true,Int64Type>/-1/0 2.325 GiB/sec 1.400
GiB/sec -39.804 True
2 BM_ReadColumn<true,DoubleType>/-1/0 2.412 GiB/sec 1.422
GiB/sec -41.059 True
10 BM_ReadColumn<true,Int32Type>/-1/0 1.454 GiB/sec 864.019
MiB/sec -41.959 True
16 BM_ReadColumn<false,DoubleType>/-1/20 3.826 GiB/sec 2.184
GiB/sec -42.899 True
0 BM_ReadColumn<false,Int64Type>/-1/50 4.669 GiB/sec 1.865
GiB/sec -60.055 True
4 BM_ReadColumn<false,Int32Type>/-1/50 3.184 GiB/sec 862.581
MiB/sec -73.546 True
```
I agree that the alternating NA/not-NA is pretty pathological so IMHO this
performance regression doesn't seem like a big deal to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
