romainfrancois commented on a change in pull request #7514:
URL: https://github.com/apache/arrow/pull/7514#discussion_r444283172
##########
File path: r/src/array_from_vector.cpp
##########
@@ -1067,12 +1110,22 @@ std::shared_ptr<arrow::DataType>
InferArrowTypeFromVector<VECSXP>(SEXP x) {
if (Rf_inherits(x, "data.frame")) {
return InferArrowTypeFromDataFrame(x);
} else {
- if (XLENGTH(x) == 0) {
- Rcpp::stop(
- "Requires at least one element to infer the values' type of a list
vector");
- }
+ SEXP ptype = Rf_getAttrib(x, symbols::ptype);
+ if (ptype == R_NilValue) {
+ if (XLENGTH(x) == 0) {
+ Rcpp::stop(
+ "Requires at least one element to infer the values' type of a list
vector");
+ }
- return arrow::list(InferArrowType(VECTOR_ELT(x, 0)));
+ return arrow::list(InferArrowType(VECTOR_ELT(x, 0)));
+ } else {
+ // special case list(raw()) -> BinaryArray
+ if (TYPEOF(ptype) == RAWSXP) {
+ return arrow::binary();
+ }
+
+ return arrow::list(InferArrowType(ptype));
Review comment:
Oh yeah that makes sense. Although this only looks at the attribute, not
specifically that it is a `vctrs_list_of` but on the arrow -> R conversion, I
think it does not hurt to make it a `vctrs_list_of`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
