jorisvandenbossche commented on a change in pull request #7537:
URL: https://github.com/apache/arrow/pull/7537#discussion_r445495780
##########
File path: cpp/src/arrow/python/helpers.cc
##########
@@ -254,14 +255,45 @@ bool PyFloat_IsNaN(PyObject* obj) {
return PyFloat_Check(obj) && std::isnan(PyFloat_AsDouble(obj));
}
+namespace {
+
+static std::once_flag pandas_static_initialized;
+static PyTypeObject* pandas_NaTType = nullptr;
+
+void GetPandasStaticSymbols() {
+ OwnedRef pandas;
+ Status s = ImportModule("pandas", &pandas);
+ if (!s.ok()) {
+ return;
+ }
+
+ OwnedRef nat_value;
+ s = ImportFromModule(pandas.obj(), "NaT", &nat_value);
+ if (!s.ok()) {
+ return;
+ }
+ PyObject* nat_type = PyObject_Type(nat_value.obj());
+ pandas_NaTType = reinterpret_cast<PyTypeObject*>(nat_type);
+
+ // PyObject_Type returns a new reference but we trust that pandas.NaT will
+ // outlive our use of this PyObject*
+ Py_DECREF(nat_type);
+}
Review comment:
Do you also want to add `pd.NA` here, or leave that for a follow-up JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
