wesm commented on a change in pull request #7537:
URL: https://github.com/apache/arrow/pull/7537#discussion_r445593243
##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -1171,6 +1171,12 @@ Status GetConverterFlat(const std::shared_ptr<DataType>&
type, bool strict_conve
Status GetConverter(const std::shared_ptr<DataType>& type, bool from_pandas,
bool strict_conversions, std::unique_ptr<SeqConverter>*
out) {
+ if (from_pandas) {
+ // ARROW-842: If pandas is not installed then null checks will be less
+ // comprehensive, but that is okay.
+ internal::InitPandasStaticData();
Review comment:
I see. Well, the problem with putting the pandas initialization
elsewhere is that we've already arranged for pandas to only be imported when
it's needed, so if we did `import pandas` always when doing `import pyarrow`
we'd be breaking that contract. I suggest we address this as follow up as needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
