kszucs commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r446147913
########## File path: python/pyarrow/_dataset.pyx ########## @@ -216,22 +216,18 @@ cdef class Expression: @staticmethod def _scalar(value): cdef: - shared_ptr[CScalar] scalar - - if value is None: - scalar.reset(new CNullScalar()) - elif isinstance(value, bool): - scalar = MakeScalar(<c_bool>value) - elif isinstance(value, float): - scalar = MakeScalar(<double>value) - elif isinstance(value, int): - scalar = MakeScalar(<int64_t>value) - elif isinstance(value, (bytes, str)): - scalar = MakeStringScalar(tobytes(value)) Review comment: Removed it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org