projjal commented on a change in pull request #12440:
URL: https://github.com/apache/arrow/pull/12440#discussion_r827651713
##########
File path: cpp/src/gandiva/precompiled/string_ops.cc
##########
@@ -2238,6 +2255,7 @@ const char* right_utf8_int32(gdv_int64 context, const
char* text, gdv_int32 text
*out_len = 0;
return "";
}
+
memcpy(ret, text + start_byte_pos, *out_len);
Review comment:
There was no need to do malloc and memcpy here. You can remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
