tustvold commented on code in PR #1583:
URL: https://github.com/apache/arrow-rs/pull/1583#discussion_r853812149
##########
arrow/src/ipc/reader.rs:
##########
@@ -1483,23 +1483,33 @@ mod tests {
}
#[test]
- fn test_roundtrip_stream_nested_dict_dict_in_map() {
- let values = StringArray::from_iter_values(["a", "b", "c"]);
- let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
- let dict_array = DictionaryArray::<Int8Type>::try_new(&keys,
&values).unwrap();
-
- let keys_array = Int32Array::from_iter_values([0, 0, 1, 2, 0, 1]);
- let keys_field = Field::new("keys", DataType::Int32, false);
+ fn test_roundtrip_stream_nested_dict_of_map_of_dict() {
+ let values = StringArray::from(vec![Some("a"), None, Some("b"),
Some("c")]);
Review Comment:
Dictionaries store nulls in the keys and not the values, I'm not actually
sure what this will do tbh
Edit: nvm apparently you can have nulls in the dictionary :exploding_head:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
