paleolimbot commented on code in PR #12817:
URL: https://github.com/apache/arrow/pull/12817#discussion_r854358208
##########
r/tests/testthat/test-Array.R:
##########
@@ -1010,6 +1010,110 @@ test_that("auto int64 conversion to int can be disabled
(ARROW-10093)", {
})
})
+test_that("as_arrow_array() default method calls Array$create()", {
+ expect_equal(
+ as_arrow_array(1:10),
+ Array$create(1:10)
+ )
+
+ expect_equal(
+ as_arrow_array(1:10, type = float64()),
+ Array$create(1:10, type = float64())
+ )
+})
+
+test_that("as_arrow_array() works for Array", {
+ array <- Array$create(logical(), type = null())
+ expect_identical(as_arrow_array(array), array)
+ expect_equal(
+ as_arrow_array(array, type = int32()),
+ Array$create(integer())
+ )
+})
+
+test_that("as_arrow_array() works for ChunkedArray", {
+ expect_equal(
+ as_arrow_array(chunked_array(type = null())),
+ Array$create(logical(), type = null())
+ )
+
+ expect_equal(
+ as_arrow_array(chunked_array(1:3, 4:6)),
+ Array$create(1:6)
+ )
+
+ expect_equal(
+ as_arrow_array(chunked_array(1:3, 4:6), type = float64()),
+ Array$create(1:6, type = float64())
+ )
+})
+
+test_that("as_arrow_array() works for vctr_vctr types", {
+ vctr <- vctrs::new_vctr(1:5, class = "custom_vctr")
+ expect_equal(
+ as_arrow_array(vctr),
+ vctrs_extension_array(vctr)
+ )
+
+ # with explicit type
+ expect_equal(
+ as_arrow_array(
+ vctr,
+ type = vctrs_extension_type(
+ vctrs::vec_ptype(vctr),
+ storage_type = float64()
+ )
+ ),
+ vctrs_extension_array(
+ vctr,
+ storage_type = float64()
+ )
+ )
+
+ # with impossible type
+ expect_snapshot_error(as_arrow_array(vctr, type = float64()))
+})
+
+test_that("as_arrow_array() works for nested extension types", {
+ vctr <- vctrs::new_vctr(1:5, class = "custom_vctr")
+
+ nested <- tibble::tibble(x = vctr)
+ type <- infer_type(nested)
+
+ # with type = NULL
+ nested_array <- as_arrow_array(nested)
+ expect_identical(as.vector(nested_array), nested)
+
+ # with explicit type
+ expect_equal(as_arrow_array(nested, type = type), nested_array)
+
+ # with extension type
+ extension_array <- vctrs_extension_array(nested)
+ expect_equal(
+ as_arrow_array(nested, type = extension_array$type),
+ extension_array
+ )
+})
+
+test_that("as_arrow_array() default method errors for impossible cases", {
+ vec <- structure(list(), class = "class_not_supported")
+
+ # check errors simulating a call from C++
+ expect_snapshot_error(as_arrow_array(vec, from_constructor = TRUE))
+ expect_snapshot_error(
+ as_arrow_array(vec, type = float64(), from_constructor = TRUE)
+ )
+
+ # check that the errors propagate through Array$create()
+ type.class_not_supported <- function(x, ...) {
+ float64()
+ }
+
+ # slightly different error if type was specified
Review Comment:
The flip side of that is that using regex it's impossible to tell that the
error message is useful! With `expect_error_snapshot()`, the full errors are
here:
https://github.com/apache/arrow/pull/12817/files#diff-b944d8c5dbb671c5af92fedc0598a90f27d0aed3d3811175fa557c3ccf6cd339
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
