emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r854724679
##########
cpp/src/arrow/filesystem/gcsfs.cc:
##########
@@ -690,11 +763,19 @@ Result<GcsOptions> GcsOptions::FromUri(const
arrow::internal::Uri& uri,
options_map.emplace(kv.first, kv.second);
}
- if (!uri.password().empty() || !uri.username().empty()) {
- return Status::Invalid("GCS does not accept username or password.");
+ const std::string& username = uri.username();
+ bool anonymous = username == "anonymous";
+ if (!username.empty() && !anonymous) {
+ return Status::Invalid("GCS URIs do not accept username except
\"anonymous\".");
+ }
+ if (!uri.password().empty()) {
+ return Status::Invalid("GCS URIs do not accept password.");
+ }
+ if (!uri.password().empty()) {
+ return Status::Invalid("GCS URIs do not accept password.");
}
Review Comment:
removed.
##########
dev/tasks/tasks.yml:
##########
@@ -431,7 +431,7 @@ tasks:
{############################## Wheel OSX ####################################}
# enable S3 support from macOS 10.13 so we don't need to bundle curl, crypt
and ssl
-{% for macos_version, macos_codename, arrow_s3 in [("10.9", "mavericks",
"OFF"),
+{% for macos_version, macos_codename, arrow_s3_gcs in [("10.9", "mavericks",
"OFF"),
Review Comment:
done.
##########
cpp/src/arrow/util/config.h.cmake:
##########
@@ -45,6 +45,7 @@
#cmakedefine ARROW_IPC
#cmakedefine ARROW_JSON
+#cmakedefine ARROW_GCS
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
