sanjibansg commented on code in PR #12977:
URL: https://github.com/apache/arrow/pull/12977#discussion_r862058051
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -847,7 +847,8 @@ ParquetDatasetFactory::CollectParquetFragments(const
Partitioning& partitioning)
auto row_groups = Iota(metadata_subset->num_row_groups());
auto partition_expression =
- partitioning.Parse(StripPrefixAndFilename(path,
options_.partition_base_dir))
+ partitioning
+ .Parse(StripPrefixAndFilename(path,
options_.partition_base_dir).directory)
Review Comment:
Now that we are using the `PartitionPathFormat` as the argument, the
`Parse()` method will work accordingly as per the partitioning mode. Any
particular test you want here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
