thisisnic commented on code in PR #13038: URL: https://github.com/apache/arrow/pull/13038#discussion_r865064555
########## r/R/csv.R: ########## @@ -135,6 +135,8 @@ #' write.csv(mtcars, file = tf) #' df <- read_csv_arrow(tf) #' dim(df) +#' # Can specify the encoding of the file +#' df <- read_csv_arrow(tf, read_options = CsvReadOptions$create(encoding = "utf8")) Review Comment: Thanks for this PR! I'm in favour of making things easier for users, and these doc updates are definitely important, but I'm a little opposed to including examples using the `CsvReadOptions$create()` type syntax. I wonder if a solution would be to merge this as-is, but open up a JIRA for a follow-up PR which allows users to pass a named list into `read_options`, on which we call `CSVReadOptions$create()`, so this example could be rewritten as: `df <- read_csv_arrow(tf, read_options = list(encoding = "utf8"))`. @jonkeane - would be good to get your thoughts here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
