thisisnic commented on code in PR #13038: URL: https://github.com/apache/arrow/pull/13038#discussion_r865747450
########## r/R/csv.R: ########## @@ -135,6 +135,8 @@ #' write.csv(mtcars, file = tf) #' df <- read_csv_arrow(tf) #' dim(df) +#' # Can specify the encoding of the file +#' df <- read_csv_arrow(tf, read_options = CsvReadOptions$create(encoding = "utf8")) Review Comment: Apologies, @eitsupi , I had previously tagged the wrong person in my original comment above! Good point that it is documented there, though I wonder how many R users would think to use the pyarrow docs. I think that your original point still stands that it needs documenting. I've opened this JIRA ticket to make the relevant changes and then subsequently document the encoding argument: https://issues.apache.org/jira/browse/ARROW-16480 . Thanks for flagging this up - I think passing through arguments as a list is going to make this much nicer for end-users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
