wjones127 commented on PR #13108: URL: https://github.com/apache/arrow/pull/13108#issuecomment-1129152903
> Shouldn't we be able to remove `ARROW_EXPORT` from `Span` in `tracing.h`? I think that is the problem in this case. @westonpace Worked before I rebase, but looks like #13040 introduced a reference to `arrow::util::tracing::Span` here: https://github.com/apache/arrow/blob/5f7a5a4574526da0493fd9dfa9e0a9c573bfcf3b/cpp/src/arrow/dataset/file_base.cc#L486 Should I replace that with something like below? https://github.com/apache/arrow/blob/5f7a5a4574526da0493fd9dfa9e0a9c573bfcf3b/cpp/src/arrow/dataset/file_csv.cc#L182-L185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
