westonpace commented on PR #13108: URL: https://github.com/apache/arrow/pull/13108#issuecomment-1129261349
Ah, that will be a problem. Well, `Impl`, `std::unique_ptr` and `ARROW_EXPORT` are not going to work together well. If a type is exported and used in `std::unique_ptr` then the type has to be fully defined becuase "windows". Is there any chance we could get rid of the pimpl pattern and just use a virtual class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
